Shubhendu Tripathi has posted comments on this change.
Change subject: engine: update the rebalance task status correctly in stop
rebalance
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
One minor comment
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRebalanceGlusterVolumeCommand.java
Line 64: }
Line 65:
Line 66: GlusterVolumeTaskStatusEntity rebalanceStatusEntity =
Line 67: (GlusterVolumeTaskStatusEntity)
vdsReturnaValue.getReturnValue();
Line 68: JobExecutionStatus stepStatus =
rebalanceStatusEntity.getStatusSummary().getStatus();
May be null check for rebalanceStatusEntity.getStatusSummary()
Line 69: if (stepStatus != null &&
JobExecutionStatus.FINISHED.equals(stepStatus)) {
Line 70: endStepJob(stepStatus, getStepMessageMap(stepStatus),
true);
Line 71: } else {
Line 72: endStepJob(JobExecutionStatus.ABORTED,
getStepMessageMap(JobExecutionStatus.ABORTED), false);
--
To view, visit http://gerrit.ovirt.org/20524
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a689db9a7651a5a48e1ffea70fc59431554e2bc
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
