Moti Asayag has posted comments on this change.
Change subject: gluster : In the task tab, size of rebalanced files is shown
with units
......................................................................
Patch Set 4:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java
Line 238: if (task==null) {
Line 239: return null;
Line 240: }
Line 241: Map<String, String> values = getMessageMap(cluster, task);
Line 242: String message =
ExecutionMessageDirector.resolveStepMessage(stepType, values);
Isn't there an option to convert the specific value to its desired unit from
the values map and then call the
ExecutionMessageDirector.resolveStepMessage(stepType, values)
instead of resolving the message first and then parse and replace part of it ?
Line 243: if(message.contains("Total size moved")) {
Line 244: int start = message.lastIndexOf(' ') + 1;
Line 245: int end = message.length() - 1;
Line 246: String sSize = message.substring(start, end);
--
To view, visit http://gerrit.ovirt.org/20511
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea6c90a098bfddfb616bc2b8ce58c9d0bb567f66
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
