Allon Mureinik has posted comments on this change. Change subject: core(wip): remove null check at executeReadList ......................................................................
Patch Set 2: Code-Review+1 The null check seems redundant: If the map contains BaseDAODbFacade.RETURN_VALUE_PARAMETER, it should be cast to List<T> and returned. If it does not, you will get a null, which is then cast to List<T> - i.e., a null. The ternary expression there is pointless, and should be removed. -- To view, visit http://gerrit.ovirt.org/19818 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54f25002701bcaa6e82a572b6fa5ed8ffa5e043a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
