Ravi Nori has posted comments on this change.
Change subject: core: Use new authentication interfaces
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java
Line 215: if (directory == null) {
Line 216: return Collections.emptyList();
Line 217: }
Line 218:
Line 219: // Run the query:
Why do we need special handling here?
Line 220: if (directory instanceof ProvisionalDirectory) {
Line 221: LdapQueryData query = new LdapQueryDataImpl();
Line 222: query.setLdapQueryType(LdapQueryType.searchGroups);
Line 223: query.setDomain(directoryName);
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbGroup.java
Line 40: externalId = directoryGroup.getId();
Line 41: domain = directoryGroup.getDirectory().getName();
Line 42: name = directoryGroup.getName();
Line 43: // XXX: distinguishedName = ldapGroup.getDistinguishedName();
Line 44: throw new RuntimeException("need to solve the problem with the
dn");
Why are you throwing a RTE in constructor of this class?
Line 45: }
Line 46:
Line 47: public Guid getId() {
Line 48: return id;
--
To view, visit http://gerrit.ovirt.org/20412
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d5d6ee41b5373328eaf2f8448efe8e598609651
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
