Allon Mureinik has posted comments on this change.
Change subject: core : Add queuing capabilities to ThreadPoolUtil
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
Looks good except for the formatting issue.
Eli/Roy - who can ack this?
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandTest.java
Line 43: protected static final Guid HOOK_ID2 = new
Guid("d222f73-fa22-4a42-93f0-d5e4c069a43e");
Line 44:
Line 45: @ClassRule
Line 46: public static MockConfigRule mcr = new MockConfigRule(
Line 47: mockConfig(ConfigValues.DefaultMaxThreadWaitQueueSize, 10),
Something really off with the indentation here - please format
Line 48: mockConfig(ConfigValues.DefaultMinThreadPoolSize,10),
Line 49: mockConfig(ConfigValues.DefaultMaxThreadPoolSize,
20));
Line 50:
Line 51: @Mock
--
To view, visit http://gerrit.ovirt.org/19744
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab7054c77c9ec8795de85df0fd45dde06c18ab1e
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <liran.zel...@gmail.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <liran.zel...@gmail.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
