Michael Pasternak has posted comments on this change.
Change subject: cli: add the option to retrieve partial history using
CLI(#957499)
......................................................................
Patch Set 7: Code-Review-1
(1 comment)
....................................................
File src/ovirtcli/infrastructure/historymanager.py
Line 106: def printHistoryItemAtIndex(self, stdout, slide, h_item):
Line 107: hformat = '[%d] %s'
Line 108: if h_item:
Line 109: stdout.write(hformat % (slide , str(h_item)))
Line 110: stdout.write('\n')
ravi,
HistoryManager doesn't responsible for the representation logic, it only
maintain history related operations,
instead of printing from HistoryManager, please add "from_index, to_index" as
optional arguments to list() method,
and do actual printing in the command/s consuming HistoryManager content
thanks.
--
To view, visit http://gerrit.ovirt.org/20272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2321ccc7e3cce2521e0b86f67de2797a8a2b4276
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
