Eli Mesika has posted comments on this change. Change subject: core: Extract deviceId from specParams of VmDevice ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java Line 54: struct.add(VdsProperties.SpecParams, StringUtils.string2Map(getNewMonitorSpecParams())); I think that after all your changes, we should change the address to use the same method as spec_params and then we can remove the string2amap and map2string methods -- To view, visit http://gerrit.ovirt.org/3762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72c88819c21648b15e9aee5d22890e7d9e2efb31 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
