Alon Bar-Lev has posted comments on this change. Change subject: engine,userportal,webadmin: rearrange uris ......................................................................
Patch Set 8: (4 comments) .................................................... File backend/manager/modules/services/src/main/webapp/WEB-INF/web.xml Line 43: </servlet> Line 44: <servlet-mapping> Line 45: <servlet-name>PKIResourceServlet.engine.ssh</servlet-name> Line 46: <url-pattern>/engine.ssh.key.txt</url-pattern> Line 47: <url-pattern>/rhevm.ssh.key.txt</url-pattern> I thought we can set the parameters at the root web.xml and just call single servlet here... I expect only register the PKIResourceServlet here at some name, let's say /pkiResource and handle the customization before forward at root web.xml Line 48: </servlet-mapping> Line 49: Line 50: <!-- Servlet for automatic registration of hypervisors: --> Line 51: <servlet> Line 55: <servlet-mapping> Line 56: <servlet-name>RegisterServlet</servlet-name> Line 57: <url-pattern>/OvirtEngineWeb/register</url-pattern> Line 58: <url-pattern>/OvirtEngineWeb/VdsAutoRegistration.aspx</url-pattern> Line 59: <url-pattern>/RHEVManagerWeb/VdsAutoRegistration.aspx</url-pattern> Can we move this to /registerHost Line 60: </servlet-mapping> Line 61: Line 62: <!-- Servlet used to validate sessions (used by the reports Line 63: integration): --> Line 67: </servlet> Line 68: <servlet-mapping> Line 69: <servlet-name>ValidateSession</servlet-name> Line 70: <url-pattern>/OvirtEngineWeb/ValidateSession</url-pattern> Line 71: </servlet-mapping> can we move this to /getSessionUser? Line 72: Line 73: <servlet> Line 74: <servlet-name>GetAttachmentServlet</servlet-name> Line 75: <servlet-class>org.ovirt.engine.core.services.GetAttachmentServlet</servlet-class> .................................................... File packaging/services/ovirt-engine/ovirt-engine.conf.in Line 126: # separated files or directories that should exist under Line 127: # /usr/share/ovirt-engine: Line 128: # Line 129: ENGINE_APPS=engine.ear Line 130: ENGINE_URI=ovirt-engine /ovirt-engine? Line 131: Line 132: # Line 133: # Flags to enable or disable the web server (the proxy) and the Line 134: # connectors of the application server: -- To view, visit http://gerrit.ovirt.org/20473 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cb4822f6bf4d372715e12858635db5ed3edd115 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
