Saggi Mizrahi has uploaded a new change for review.
Change subject: fixup: Instantiate vdsManagers in a less convoluted manner
......................................................................
fixup: Instantiate vdsManagers in a less convoluted manner
Change-Id: Icccfdd8df3c921e925b49944aece756dd7dbd87d
Signed-off-by: Saggi Mizrahi <smizr...@redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
2 files changed, 2 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/19/20619/1
diff --git
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
index b35ce48..46bc892 100644
---
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
+++
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
@@ -151,7 +151,7 @@
}
public void AddVds(VDS vds, boolean isInternal) {
- VdsManager vdsManager = VdsManager.buildVdsManager(vds);
+ VdsManager vdsManager = new VdsManager(vds);
if (isInternal) {
VDSStatus status = vds.getStatus();
switch (vds.getStatus()) {
diff --git
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
index 3aae7ce..c721ff7 100644
---
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
+++
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
@@ -131,7 +131,7 @@
private final Guid _vdsId;
- private VdsManager(VDS vds) {
+ public VdsManager(VDS vds) {
log.info("Entered VdsManager constructor");
_vds = vds;
_vdsId = vds.getId();
@@ -161,11 +161,6 @@
InitVdsBroker();
_vds = null;
- }
-
- public static VdsManager buildVdsManager(VDS vds) {
- VdsManager vdsManager = new VdsManager(vds);
- return vdsManager;
}
public void schedulJobs() {
--
To view, visit http://gerrit.ovirt.org/20619
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icccfdd8df3c921e925b49944aece756dd7dbd87d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
