Omer Frenkel has posted comments on this change.
Change subject: engine: Audit log for brick status change
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
Line 802: GlusterStatus fetchedStatus =
brickStatusMap.get(brick.getId());
Line 803: // if fetchedStatus is null, it means this is a new brick
added from gluster cli and doesn't exist in engine
Line 804: // DB yet. Don't do anything, wait for it to be added by
the 'lightweight' refresh job
Line 805: if (fetchedStatus != null && fetchedStatus !=
brick.getStatus()) {
Line 806: logBrickStatusChange(volume, brick, fetchedStatus);
how often do you expect this to happen?
just want to make sure audit log will not be flooded in any scenario
Line 807: brick.setStatus(fetchedStatus);
Line 808: bricksToUpdate.add(brick);
Line 809: }
Line 810: }
--
To view, visit http://gerrit.ovirt.org/20433
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If1764dd5c41b484637595b0fa20598849f9ba347
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
