Yedidyah Bar David has posted comments on this change.

Change subject: packaging: engine-backup: Safer password input
......................................................................


Patch Set 10:

(1 comment)

....................................................
File packaging/bin/engine-backup.sh
Line 446:               }
Line 447: 
Line 448:               trap cleanup 0
Line 449:               [ -t 0 ] || die "Standard input is not a terminal"
Line 450:               STTY_ORIG="$(stty -g)"
Right. Thanks.
Line 451:               stty -echo || die "Failed to disable terminal input 
echo"
Line 452:               echo -n "Enter database password: " >&2
Line 453:               read dbpass
Line 454:               echo >&2


-- 
To view, visit http://gerrit.ovirt.org/20423
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbc497af2653417beab54a9be307332cdf69a48a
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to