Roy Golan has posted comments on this change.
Change subject: tools: Validate TimeZone values in engine-config
......................................................................
Patch Set 2:
(2 comments)
....................................................
File
backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/GeneralTimeZoneValueHelper.java
Line 9: }
Line 10:
Line 11: @Override
Line 12: public String getHelpNoteType() {
Line 13: return "time zone";
... is this what you want the user to see in the help incase he needs help?
Line 14: }
....................................................
File
backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/WindowsTimeZoneValueHelper.java
Line 9: }
Line 10:
Line 11: @Override
Line 12: public String getHelpNoteType() {
Line 13: return "time zone for Windows OS";
same. explain the format, an example usage, and why there's a distinction from
non-windows values
Line 14: }
--
To view, visit http://gerrit.ovirt.org/20501
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78c056128f1fcd607e9baa882e24544c99ad7cd2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbe...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Martin Betak <mbe...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
