Lior Vernia has posted comments on this change. Change subject: webadmin: VnicProfilesEditor to inherit AddRemoveRowWidget ......................................................................
Patch Set 1: Sure, "half" refers to this being only one of the two widgets that should be refactored to inherit from AddRemoveRowWidget. This only affects the vNIC section of the add/edit network dialog, so a succeeding patch would have to take care of the custom properties widget (which resides in the add/edit vNIC profile dialog if I'm not mistaken). -- To view, visit http://gerrit.ovirt.org/20492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If66c23bddada57fbfd95292dc2cc1f6c8d9df19e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
