Gilad Chaplik has posted comments on this change.

Change subject: core: fix issue with search on OSs
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

....................................................
File 
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/OsValueAutoCompleter.java
Line 24: 
Line 25:     @Override
Line 26:     public String[] getCompletion(String wordPart) {
Line 27:         if (wordPart == null || wordPart.isEmpty()) {
Line 28:             return map.values().toArray(new String[]{});
consider creating this array once.
Line 29:         }
Line 30:         List<String> list = new ArrayList<String>();
Line 31:         for (String osName : map.values()) {
Line 32:             if (osName.contains(wordPart)) {


-- 
To view, visit http://gerrit.ovirt.org/20396
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9434189173939ba595862a40483d8da5107228b2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to