Lior Vernia has posted comments on this change.
Change subject: engine: block editing migraion fields while VM !Down
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
Line 1572:
Line 1573: @DefaultStringValue("Attach a VirtIO-SCSI controller when
running the VM")
Line 1574: String isVirtioScsiEnabledInfo();
Line 1575:
Line 1576: @DefaultStringValue("The fields under 'Start Running On' and
'Migration Options' aren't editable while the VM isn't down")
Since the UI fields themselves are still editable (correct me if I'm wrong, I
don't see anything in this patch changing that), I think a better message might
be something like "Changes made to the 'Start Running On' and 'Migration
Options' will only take effect once the VM is re-run".
Line 1577: String nonEditableMigrationFieldsWhileVmNotDownInfo();
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
Line 469: <t:tab>
Line 470: <t:DialogTab ui:field="hostTab">
Line 471: <t:content>
Line 472: <g:FlowPanel>
Line 473: <d:InfoIcon
ui:field="nonEditableWhileVmNotDownInfo"
addStyleNames="{style.labelToCoupleCoupleLeft}"/>
Consider replacing the InfoIcon simply by a label in italic that would appear
in a single line, above the panels. The InfoIcon currently looks like it refers
to the "Start Running On" section (and it's kinda weird that it's to the left
and not to the right).
Line 474: <g:Label
addStyleNames="{style.sectionLabel}" text="{constants.runOnVmPopup}" />
Line 475: <g:VerticalPanel
addStyleNames="{style.runHostPanel}" verticalAlignment='ALIGN_MIDDLE'>
Line 476:
<e:EntityModelRadioButtonEditor ui:field="isAutoAssignEditor"
Line 477:
addStyleNames="{style.radioButton}" />
--
To view, visit http://gerrit.ovirt.org/20444
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If9fb2fc0755317a8d4be7628b56966d82e9adc3a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
