Sandro Bonazzola has posted comments on this change.
Change subject: Suggest using filters if there are more than 10 hosts.
......................................................................
Patch Set 2:
(2 comments)
....................................................
File src/__main__.py
Line 1172: def get_hypervisor_data(self):
Line 1173: hosts = self.conf.get("hosts")
Line 1174:
Line 1175: if hosts:
Line 1176: # Check if there are more than MAX_WARN_HOSTS_COUNT hosts
I think that --quiet here is used like a --unattended so maybe also this
question should be avoided if --quiet is specified
Line 1177: # to collect from
Line 1178: _max_warn_hosts = False
Line 1179: if len(hosts) >= MAX_WARN_HOSTS_COUNT:
Line 1180: _max_warn_hosts = True
Line 1193: _("Aborting hypervisor collection...")
Line 1194: )
Line 1195: return
Line 1196:
Line 1197: if not self.conf.get("quiet"):
If you use elif above, you can avoid to tuse _max_warn_hosts and avoid 1
indentation level
Line 1198: if not _max_warn_hosts:
Line 1199: continue_ = get_from_prompt(
Line 1200: msg="About to collect information from "
Line 1201: "{len} hypervisors. Continue? (Y/n):
".format(
--
To view, visit http://gerrit.ovirt.org/20485
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I05fad1b52c1672b45d0199091cb60b9642581621
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
