Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: refactoring
......................................................................
Patch Set 1:
(6 comments)
....................................................
File ovirt-engine.spec.in
Line 818
Line 819
Line 820
Line 821
Line 822
ok
Line 819
Line 820
Line 821
Line 822
Line 823
ok
Line 821
Line 822
Line 823
Line 824
Line 825
me neither, should it be in its own package?
Line 492: %endif
Line 493:
Line 494: %package setup-plugin-websocket-proxy
Line 495: Summary: Setup and upgrade specific plugins for websocket-proxy
Line 496: Requires: %{name}-setup-plugin-ovirt-engine-common
so is it better to move core plugins for logging init and action init to -setup
instead of having them in -common?
Line 497:
Line 498: %description setup-plugin-websocket-proxy
Line 499: Setup and upgrade specific plugins for websocket-proxy
Line 500:
Line 854: %{engine_data}/bin/ovirt-engine-log-setup-event.sh
Line 855: %{engine_data}/setup/bin/ovirt-engine-remove
Line 856: %{engine_data}/setup/bin/ovirt-engine-setup
Line 857: %{engine_data}/setup/bin/ovirt-engine-setup.env
Line 858: %{engine_data}/setup/bin/ovirt-engine-upgrade-check
Well ovirt-engine-setup will check for upgrade anyway, so I think it's correct
to let the user check for upgrade before running it.
Line 859:
Line 860: %{engine_state}/backups/
Line 861: %{engine_state}/setup/
Line 862: # Legacy
Line 893: %{engine_data}/setup/plugins/ovirt-engine-remove/db/
Line 894: %{engine_data}/setup/plugins/ovirt-engine-remove/files/
Line 895: %{engine_data}/setup/plugins/ovirt-engine-remove/network/
Line 896: %{engine_data}/setup/plugins/ovirt-engine-remove/system/
Line 897: %{engine_data}/setup/plugins/ovirt-engine-rename/
maybe
Line 898:
Line 899: %files setup-plugin-ovirt-engine-common
Line 900:
Line 901: %{engine_data}/setup/ovirt_engine_setup/
--
To view, visit http://gerrit.ovirt.org/20293
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I572da9cd7b4a2b9e1fdfee4c05e83a0ca31b99bc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
