Yedidyah Bar David has posted comments on this change.
Change subject: packaging: engine-backup: Prevent password on command line
......................................................................
Patch Set 3:
(2 comments)
....................................................
File packaging/bin/engine-backup.sh
Line 127: die "Can not read password file
${DB_PASSFILE}"
Line 128: read MY_DB_PASSWORD < "${DB_PASSFILE}"
Line 129: ;;
Line 130: --db-password)
Line 131: MY_DB_PASSWORD="$(readdbpassword)"
I might agree personally, but Ofer told me not to.
Line 132: ;;
Line 133: --db-name=*)
Line 134: MY_DB_DATABASE="${v}"
Line 135: ;;
Line 412: echo 1>&2
Line 413: cat << __EOF__
Line 414: ${dbpass}
Line 415: __EOF__
Line 416: )
Added different error messages.
Line 417: }
Line 418:
Line 419: ## Main
Line 420:
--
To view, visit http://gerrit.ovirt.org/20423
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbc497af2653417beab54a9be307332cdf69a48a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
