Sergey Gotliv has posted comments on this change.
Change subject: webadmin: Expose read-only disk functionality in UI.
......................................................................
Patch Set 3:
(5 comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml
Line 91: <g:VerticalPanel ui:field="createDiskPanel"
addStyleNames="{style.mainPanel}">
Line 92: <g:HorizontalPanel>
Line 93: <g:VerticalPanel>
Line 94: <e:EntityModelTextBoxEditor
ui:field="sizeEditor" addStyleNames="{style.boxEditor}"/>
Line 95: <e:EntityModelTextBoxEditor
ui:field="sizeExtendEditor" addStyleNames="{style.boxEditor}"/>
I reverted that change.
Line 96: <e:EntityModelTextBoxEditor
ui:field="aliasEditor" addStyleNames="{style.boxEditor}"/>
Line 97: <e:EntityModelTextBoxEditor
ui:field="descriptionEditor" addStyleNames="{style.boxEditor}"/>
Line 98: <e:ListModelListBoxEditor
ui:field="interfaceEditor" addStyleNames="{style.boxEditor}"/>
Line 99: <e:ListModelListBoxEditor
ui:field="volumeTypeEditor" addStyleNames="{style.boxEditor}"/>
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
Line 354: DiskModel diskModel = (DiskModel) target;
Line 355: ArrayList<StorageDomain> storageDomains =
(ArrayList<StorageDomain>) returnValue;
Line 356:
Line 357: ArrayList<StorageDomain> filteredStorageDomains = new
ArrayList<StorageDomain>();
Line 358: for (StorageDomain a : storageDomains) {
Done
Line 359: if (a.getStorageDomainType() !=
StorageDomainType.ISO
Line 360: && a.getStorageDomainType() !=
StorageDomainType.ImportExport
Line 361: && a.getStatus() ==
StorageDomainStatus.Active) {
Line 362: filteredStorageDomains.add(a);
Line 357: ArrayList<StorageDomain> filteredStorageDomains = new
ArrayList<StorageDomain>();
Line 358: for (StorageDomain a : storageDomains) {
Line 359: if (a.getStorageDomainType() !=
StorageDomainType.ISO
Line 360: && a.getStorageDomainType() !=
StorageDomainType.ImportExport
Line 361: && a.getStatus() ==
StorageDomainStatus.Active) {
Done
Line 362: filteredStorageDomains.add(a);
Line 363: }
Line 364: }
Line 365:
Line 789: getDisk().setShareable((Boolean)
getIsShareable().getEntity());
Line 790: getDisk().setPlugged((Boolean) getIsPlugged().getEntity());
Line 791: getDisk().setPropagateErrors(PropagateErrors.Off);
Line 792:
Line 793: if (getIsReadOnly().getIsAvailable()) {
I have no problem to make it ternary.
Line 794: getDisk().setReadOnly((Boolean)
getIsReadOnly().getEntity());
Line 795: } else {
Line 796: getDisk().setReadOnly(false);
Line 797: }
Line 792:
Line 793: if (getIsReadOnly().getIsAvailable()) {
Line 794: getDisk().setReadOnly((Boolean)
getIsReadOnly().getEntity());
Line 795: } else {
Line 796: getDisk().setReadOnly(false);
Done
Line 797: }
Line 798: }
Line 799:
Line 800: @Override
--
To view, visit http://gerrit.ovirt.org/20185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c8d98df5e9b7aa8130b45b1ca036219175b70bf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
