Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Support tab index handling in dialogs ......................................................................
Patch Set 5: (1 comment) .................................................... File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.java Line 138 Line 139 Line 140 Line 141 Line 142 Exactly, tab index handling is now driven by AbstractModelBoundPopupPresenterWidget (ViewDef.updateTabIndexes) and implemented by AbstractModelBoundPopupView. Code I've deleted here isn't relevant anymore since it's now done in AbstractModelBoundPopupView.updateTabIndexes method. Generally speaking: * each popup view (extends AbstractModelBoundPopupView) can assign tab indexes to its "child" widgets simply by overriding setTabIndexes method, just like HostPopupView does today * for popup views whose content is represented by a separate widget (extends AbstractModelBoundWidgetPopupView), the widget itself (AbstractModelBoundPopupWidget) can assign tab indexes to its "child" widgets simply by overriding setTabIndexes method * in any case, dialog footer buttons have tab indexes assigned automatically (AbstractModelBoundPopupView.updateTabIndexes) for both kinds of popup views -- To view, visit http://gerrit.ovirt.org/19692 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b5c7d6a9e7b98c1f5e1fecbaaf193cd862ccb47 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
