Vojtech Szocs has abandoned this change. Change subject: webadmin,userportal: (WiP) Use GWT standard RPC instead of deRPC ......................................................................
Abandoned This patch seems to be more risky than I originally anticipated. Preliminary Selenium tests detected serialization-related errors at runtime (compiled WebAdmin application) so the next step was to analyze the generated JavaScript to pin-point the problem. However, passing -draftCompile option to GWT compiler [Enable faster, but less-optimized, compilations] makes GWT compiler crash on java.lang.NullPointerException when using Standard GWT RPC: com.google.gwt.dev.jjs.impl.GenerateJavaScriptAST$GenerateJavaScriptVisitor.endVisit(GenerateJavaScriptAST.java:1219) Which maps to following line: qualifier = polymorphicNames.get(method).makeRef(x.getSourceInfo()); So it seems that above-mentioned line throws NPE when running GWT compiler with -draftCompile option, but works OK without -draftCompile (default behavior). Note that this happens ONLY when using Standard GWT RPC, i.e. ONLY with changes made by this patch. The root cause seems to be: com.google.gwt.user.client.rpc.impl.SerializerBase.deserialize(SerializerBase.java:95) Which maps to following line: typeHandler.deserial(stream, instance); The above-mentioned code is referenced by com.google.gwt.user.client.rpc.impl.ClientSerializationStreamReader in its deserialize method. Unfortunately, I wasn't able to get hold of actual "typeSignature" value for that method. In any case, ClientSerializationStreamReader is very likely the culprit also in case of serialization-related errors detected during preliminary Selenium tests. To summarize, this patch is quite risky as it introduces unexpected serialization-related errors at runtime and even GWT compiler error (related to serialization) when using -draftCompile option. Because of that, I'm abandoning this patch for now (we might revisit it again later, if necessary). -- To view, visit http://gerrit.ovirt.org/19122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ib6a4a6ef2eb620cf7050b7c7c2688cadc3b9d6f5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
