Lior Vernia has uploaded a new change for review. Change subject: webadmin: Only close provider dialog if action succeeds ......................................................................
webadmin: Only close provider dialog if action succeeds Give the dialog a chance to display an error message from the backend before closing. Change-Id: I8ecf9d1364935a2a9231b44131eca5ca725d6db6 Bug-Url: https://bugzilla.redhat.com/987949 Signed-off-by: Lior Vernia <lver...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/93/20393/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java index cb5f247..3167a27 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java @@ -38,7 +38,6 @@ import org.ovirt.engine.ui.uicompat.IEventListener; import org.ovirt.engine.ui.uicompat.IFrontendActionAsyncCallback; -@SuppressWarnings("deprecation") public class ProviderModel extends Model { private static final String CMD_SAVE = "OnSave"; //$NON-NLS-1$ @@ -293,9 +292,9 @@ @Override public void executed(FrontendActionAsyncResult result) { sourceListModel.getSearchCommand().execute(); + cancel(); } }); - cancel(); } private void onSave() { -- To view, visit http://gerrit.ovirt.org/20393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8ecf9d1364935a2a9231b44131eca5ca725d6db6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
