Alon Bar-Lev has posted comments on this change.

Change subject: packaging: engine-backup.sh fix info on failed restore
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

Minor notes.

....................................................
File packaging/bin/engine-backup.sh
Line 76: 
Line 77:  Open access in the firewall/iptables/etc. to the postgresql port,
Line 78:  5432 by default.
Line 79: 
Line 80:  Open access in postgresql by adding to pg_hba.conf (which is
I would have wrote this the exact opposite order :)

1. make sure database enables have network connectivity

<snip>

2. make sure firewall is opened for tcp/5432 which is the default postgresql 
port.

3. create database to restore into

<snip>

BTW: /var/lib/pgsql/data is not platform independent... but not that important.
Line 81:  by default in /var/lib/pgsql/data) lines like these:
Line 82: 
Line 83:  host    <database>      <user>          0.0.0.0/0               md5
Line 84:  host    <database>      <user>          ::0/0                   md5


-- 
To view, visit http://gerrit.ovirt.org/20374
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I212bfdd3b362880faa7aee159866d928de83d6f3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to