Omer Frenkel has posted comments on this change.

Change subject: core:  [TEXT] restore.sh woes, unable to...
......................................................................


Patch Set 4:

(1 comment)

code looks ok minor comment inside,
need also +1 from infra as well

....................................................
File packaging/dbscripts/restore.sh
Line 13: set_defaults
Line 14: 
Line 15: usage() {
Line 16:        printf "Usage: ${ME} [-h] [-s SERVERNAME] [-p PORT] -u USERNAME 
-d DATABASE -f FILE [-o] \n"
Line 17:         printf "This script must run with a DB engine user credentials"
DB engine user or super user? (in the commit you mention super user)
Line 18:        printf "\n"
Line 19:        printf "\t-s SERVERNAME - The database servername for the 
database (def. ${SERVERNAME})\n"
Line 20:        printf "\t-p PORT       - The database port for the database    
   (def. ${PORT})\n"
Line 21:        printf "\t-u USERNAME   - The username for the database         
   (def. engine)\n"


-- 
To view, visit http://gerrit.ovirt.org/19329
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44921d6fac57cfc565dacca52ed5a6d3b5b57f66
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to