Maor Lipchuk has posted comments on this change. Change subject: core: Add warning when deactivate ISO domain. ......................................................................
Patch Set 2: @Allon - Two reasons: * because the ISO file can still be read if the domain is deactivated, since it is still mounted in the Host (see https://bugzilla.redhat.com/show_bug.cgi?id=969641#c7) * There is also another bug described in https://bugzilla.redhat.com/show_bug.cgi?id=969641#c6 : "Take in notice that there is a bug that when user ejects the CD of the running VM, VDSM still reports the device is attached." - So, blocking this operation will just cause inconvinient to the user. -- To view, visit http://gerrit.ovirt.org/20331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47c1a8155762ecd0b04bb17676151946982bb919 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches