Sahina Bose has posted comments on this change.
Change subject: restapi: Add link to job for actions, when job exists
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendActionableResource.java
Line 72: protected Response doAction(final VdcActionType task, final
VdcActionParametersBase params, final Action action,
AbstractBackendResource.PollingType pollingType) {
Line 73: awaitGrace(action);
Line 74: try {
Line 75: VdcReturnValueBase actionResult = doAction(task, params);
Line 76: if (actionResult.getJobId() != null) {
Shouldn't we add this only in case of async actions? Maybe check if
action.isAsync() == true, in addition to jobId != null check.
Line 77: setJobLink(action, actionResult);
Line 78: }
Line 79: if (actionResult.getHasAsyncTasks()) {
Line 80: if (expectBlocking(action)) {
--
To view, visit http://gerrit.ovirt.org/20363
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie39395e30970ace08e8c7de3148adb3f958f1937
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
