Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: clean '&' in jdbcTlsOptions
......................................................................
Patch Set 1:
(1 comment)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/config/database.py
Line 87: securedValidation=self.environment[
Line 88: osetupcons.DBEnv.SECURED_HOST_VALIDATION
Line 89: ],
Line 90: jdbcTlsOptions='&'.join(
Line 91: s for s in
suggest indent in as we usually do:
s for s in (
bla,
bla,
) if s
this if s python wise is ugly... made me pause...
Line 92: (
Line 93: 'ssl=true'
Line 94: if self.environment[
Line 95: osetupcons.DBEnv.SECURED
--
To view, visit http://gerrit.ovirt.org/20361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8bb485e03c9d9d4c967f763a157151b11cbb84d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
