Roy Golan has posted comments on this change.
Change subject: core: Detect host in idle prep for maintenance and re-migrate
......................................................................
Patch Set 14:
(3 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java
Line 70: }
Line 71:
Line 72: private void cancelIncommingMigrations() {
Line 73: for (Guid hostId :vdssToMaintenance.keySet()) {
Line 74: for (VM vm :
getVmDAO().getAllRunningOnOrMigratingToVds(hostId)) {
I'm falling back to what I did in first place with minor chage
Line 75: if (vm.getStatus() == VMStatus.MigratingFrom) {
Line 76: log.infoFormat("Cancelling incoming migration of
{0}", vm);
Line 77: runVdsCommand(VDSCommandType.CancelMigrate, new
CancelMigrationVDSParameters(vm.getRunOnVds(), vm.getId(), true));
Line 78: }
Line 72: private void cancelIncommingMigrations() {
Line 73: for (Guid hostId :vdssToMaintenance.keySet()) {
Line 74: for (VM vm :
getVmDAO().getAllRunningOnOrMigratingToVds(hostId)) {
Line 75: if (vm.getStatus() == VMStatus.MigratingFrom) {
Line 76: log.infoFormat("Cancelling incoming migration of
{0}", vm);
done
Line 77: runVdsCommand(VDSCommandType.CancelMigrate, new
CancelMigrationVDSParameters(vm.getRunOnVds(), vm.getId(), true));
Line 78: }
Line 79: }
Line 80: }
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java
Line 60: boolean restartVds(Guid vdsId);
Line 61:
Line 62: void addExternallyManagedVms(List<VmStatic> externalVmList);
Line 63:
Line 64: void moveToMaintenance(VDS vds);
the name was all wrong. the name decribed what I'm doing rather the event
itself.
changed that
--
To view, visit http://gerrit.ovirt.org/17942
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e18bcfbc566b6fd92d276c5c739ba607e2a53f0
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
