Moti Asayag has posted comments on this change.

Change subject: core: no job desc for AddVmFromSnapshot
......................................................................


Patch Set 1:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java
Line 425:     public Map<String, String> getJobMessageProperties() {
Line 426:         if (jobProperties == null) {
Line 427:             jobProperties = super.getJobMessageProperties();
Line 428:             
jobProperties.put(VdcObjectType.Snapshot.name().toLowerCase(),
Line 429:                     (getSnapshotName() == null) ? "" : 
getSnapshotName());
you can simplify this by StringUtiles.defaultString(getSnapshotName())
Line 430:         }
Line 431:         return jobProperties;
Line 432:     }


-- 
To view, visit http://gerrit.ovirt.org/20320
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28ff6aa5bef6b39122071bee7582af2e74688156
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to