Gilad Chaplik has posted comments on this change.

Change subject: engine: Copying a quota drops consumers and permissions
......................................................................


Patch Set 1:

(2 comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddQuotaCommand.java
Line 40: 
Line 41:     @Override
Line 42:     protected void executeCommand() {
Line 43:         setQuotaParameter();
Line 44:         TransactionSupport.executeInNewTransaction(new 
TransactionMethod<Void>() {
Done
Line 45: 
Line 46:             @Override
Line 47:             public Void runInTransaction() {
Line 48:                 getQuotaDAO().save(getQuota());


Line 113:                         getCurrentUser().getUserId(),
Line 114:                         false);
Line 115:         for (permissions vmPermission : vmPermissions) {
Line 116:             
permissionsToAdd.addPermission(vmPermission.getad_element_id(), 
vmPermission.getrole_id(),
Line 117:                     getQuotaId(), VdcObjectType.Quota);
Done
Line 118:         }
Line 119:         if (!permissionsToAdd.isEmpty()) {
Line 120:             List<permissions> permissionsList = 
permissionsToAdd.asPermissionList();
Line 121:             
MultiLevelAdministrationHandler.addPermission(permissionsList.toArray(new 
permissions[permissionsList.size()]));


-- 
To view, visit http://gerrit.ovirt.org/19960
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide6f9ded5c19d16f7b4c7e373df9664e59fb1419
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to