Ramesh N has uploaded a new change for review.
Change subject: webadmin: Renaming Add Brick UI action to Add
......................................................................
webadmin: Renaming Add Brick UI action to Add
renamed the UI Action 'Add Bricks' in Bricks sub tab to just 'Add' for
UI consitency. Also 'Add Bricks' button in new volume dialog is renamed
to just 'Add'
Change-Id: Iba0e7f9752893df37fa848b76a7698e3af139bc9
Bug-Url:://bugzilla.redhat.com/show_bug.cgi?id=1019568
Signed-off-by: Ramesh Nachimuthu <rnach...@redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java
M
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
4 files changed, 9 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/18/20318/1
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java
index d327c32..d4ab710 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java
@@ -261,7 +261,7 @@
else {
ConfirmationModel model = new ConfirmationModel();
setWindow(model);
-
model.setTitle(ConstantsManager.getInstance().getConstants().addBricksVolume());
+
model.setTitle(ConstantsManager.getInstance().getConstants().addBricksTitle());
model.setMessage(ConstantsManager.getInstance()
.getConstants()
.cannotAddBricksNoUpServerFound());
@@ -289,7 +289,7 @@
volumeBrickModel.getStripeCount().setIsChangable(true);
volumeBrickModel.getStripeCount().setIsAvailable(volumeEntity.getVolumeType().isStripedType());
-
volumeBrickModel.setTitle(ConstantsManager.getInstance().getConstants().addBricksVolume());
+
volumeBrickModel.setTitle(ConstantsManager.getInstance().getConstants().addBricksTitle());
volumeBrickModel.setHashName("add_bricks"); //$NON-NLS-1$
volumeBrickModel.getVolumeType().setEntity(volumeEntity.getVolumeType());
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java
index ffd829f..ba6ac84 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java
@@ -301,7 +301,7 @@
volumeBrickModel.getStripeCount().setIsAvailable(getStripeCount().getIsAvailable());
setWindow(volumeBrickModel);
-
volumeBrickModel.setTitle(ConstantsManager.getInstance().getConstants().addBricksVolume());
+
volumeBrickModel.setTitle(ConstantsManager.getInstance().getConstants().addBricksTitle());
volumeBrickModel.setHashName("add_bricks"); //$NON-NLS-1$
AsyncQuery _asyncQuery = new AsyncQuery();
diff --git
a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
index fe82839..76d768f 100644
---
a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
+++
b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
@@ -241,6 +241,9 @@
@DefaultStringValue("New Volume")
String newVolumeTitle();
+ @DefaultStringValue("Add Bricks")
+ String addBricksTitle();
+
@DefaultStringValue("Parameters")
String parameterTitle();
@@ -1479,7 +1482,7 @@
String requestToServerFailed();
// Volume
- @DefaultStringValue("Add Bricks")
+ @DefaultStringValue("Add")
String addBricksVolume();
@DefaultStringValue("Add")
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
index 205f665..69b221d 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
@@ -2472,7 +2472,7 @@
@DefaultStringValue("RDMA")
String rdmaVolume();
- @DefaultStringValue("Add Bricks")
+ @DefaultStringValue("Add")
String addBricksVolume();
@DefaultStringValue("Type")
@@ -2636,7 +2636,7 @@
@DefaultStringValue("Status")
String statusBrick();
- @DefaultStringValue("Add Bricks")
+ @DefaultStringValue("Add")
String addBricksBrick();
@DefaultStringValue("Remove")
--
To view, visit http://gerrit.ovirt.org/20318
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba0e7f9752893df37fa848b76a7698e3af139bc9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnach...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
