Sergey Gotliv has posted comments on this change. Change subject: core: adding support for db lock of all disk snapshots ......................................................................
Patch Set 2: Code-Review+1 Patch and code look good to me. Personally, I think would be nice to have 2 methods: 1.updateAllDiskImageSnapshotsStatusWithCompensation 2.updateAllDiskImageSnapshotsStatus Because: 1. I don't like that existence of compensation context implicitly used as a decision point(if/else). 2. Calling method ...WithCompensation without compensationContext sounds weird to me. -- To view, visit http://gerrit.ovirt.org/20308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibac8daf6a9e970859a6759d84d7849e7f84e0d79 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
