Greg Padgett has posted comments on this change. Change subject: agent: temporarily drop host score upon enexpected VM shutdown ......................................................................
Patch Set 1: (1 comment) .................................................... File ovirt_hosted_engine_ha/lib/util.py Line 37: """ Line 38: if start is None: Line 39: return False Line 40: if end is None: Line 41: end = time.time() Not a problem here, because the epoch increases continuously across dst boundaries and only the hh:mm:ss representation changes. However, if a user sets the time/date without restarting the daemon it may cause a discontinuity, and that's something we can consider handling. Probably would warrant a separate patch due to the number of timers in the agent. Line 42: return (end - start >= count) Line 43: Line 44: Line 45: def mkdir_recursive(path): -- To view, visit http://gerrit.ovirt.org/20279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If11d561a39cc9723ffdd55836db693fc2aad0575 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
