Omer Frenkel has posted comments on this change.
Change subject: engine: Populate task entity on brick
......................................................................
Patch Set 5:
(1 comment)
looks ok, just formatting issue
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java
Line 317: volume.setAccessProtocols(new
HashSet<AccessProtocol>(getAccessProtocolsOfVolume(volume.getId())));
Line 318: volume.setTransportTypes(new
HashSet<TransportType>(getTransportTypesOfVolume(volume.getId())));
Line 319: volume.setAsyncTask(getAsyncTaskOfVolume(volume.getId()));
Line 320: List<GlusterBrickEntity> bricks =
dbFacade.getGlusterBrickDao().getBricksOfVolume(volume.getId());
Line 321: if (volume.getAsyncTask()!=null &&
volume.getAsyncTask().getTaskId() != null) {
please use the project formatting (missing spaces in the 'if' above and bracket
should be in the same line of the 'for' loop
Line 322: for (GlusterBrickEntity brick: bricks)
Line 323: {
Line 324: if (brick.getAsyncTask() != null &&
brick.getAsyncTask().getTaskId() != null &&
Line 325:
brick.getAsyncTask().getTaskId().equals(volume.getAsyncTask().getTaskId())) {
--
To view, visit http://gerrit.ovirt.org/20017
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f72371323ef7696313b5333707ef4f3f771e7e1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
