Ramesh N has posted comments on this change. Change subject: engine: enabling StopRemoveBrick when data migration is completed ......................................................................
Patch Set 3: (1 comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncCommandBase.java Line 85: GlusterAsyncTask asyncTask = getGlusterVolume().getAsyncTask(); Line 86: // Gluster Task will be associated with only one step ( REBALANCING_VOLUME or REMOVING_BRICK) Line 87: Step step = getStepDao().getStepsByExternalId(asyncTask.getTaskId()).get(0); Line 88: step.setStatus(status); Line 89: step.setEndTime(new Date()); It does change the status of the Step and set the ENd Date Time as its being done in step.markStepEnded(status) API. We need to do this explicitly as markStepEnded API doesn't allow us to change the step status from FINISHED to ABORTED. Line 90: step.setDescription(ExecutionMessageDirector.resolveStepMessage(getStepType(), Line 91: stepMessageMap)); Line 92: JobRepositoryFactory.getJobRepository().updateStep(step); Line 93: -- To view, visit http://gerrit.ovirt.org/20110 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88e53fa1772427ea1ae2b6943b76e9a71e772376 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
