Omer Frenkel has posted comments on this change.
Change subject: Allow activate hosts that support the engine's version
......................................................................
Patch Set 1:
(1 comment)
looks ok, minor comment
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java
Line 44: @Override
Line 45: protected void executeCommand() {
Line 46: VDS vds = getVds();
Line 47: VDSGroup cluster = getVdsGroup();
Line 48: boolean vdsmVersionSupportedByEngine = false;
i think the name should be isEngineSupportedByVdsm , not?
Line 49:
Line 50: // check that vdc support vds OR vds support vdc
Line 51: Version partialVdcVersion =
Line 52: new Version(new Version(Config.<String>
GetValue(ConfigValues.VdcVersion)).toString(2));
--
To view, visit http://gerrit.ovirt.org/19992
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I70b10f9ede37de858df0aa88185c75f2d84fc141
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
