Maor Lipchuk has posted comments on this change. Change subject: core, restapi: Introducing support for attaching disk snapshot ......................................................................
Patch Set 27: (2 comments) .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java Line 42: Line 43: drive.put(VdsProperties.Type, VmDeviceType.DISK.getName()); Line 44: addAddress(drive, getParameters().getVmDevice().getAddress()); Line 45: drive.put(VdsProperties.INTERFACE, disk.getDiskInterface().getName()); Line 46: drive.put(VdsProperties.Shareable, it does Line 47: (vmDevice.getSnapshotId() != null && FeatureSupported.hotPlugDiskSnapshot(getParameters().getVm() Line 48: .getVdsGroupCompatibilityVersion())) ? VdsProperties.Transient Line 49: : disk.isShareable()); Line 50: drive.put(VdsProperties.Optional, Boolean.FALSE.toString()); .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java Line 301: Line 302: addBootOrder(vmDevice, struct); Line 303: struct.put(VdsProperties.Shareable, Line 304: (vmDevice.getSnapshotId() != null && FeatureSupported.hotPlugDiskSnapshot(vm.getVdsGroupCompatibilityVersion())) ? VdsProperties.Transient Line 305: : disk.isShareable()); it actually does Line 306: struct.put(VdsProperties.Optional, Boolean.FALSE.toString()); Line 307: struct.put(VdsProperties.ReadOnly, String.valueOf(vmDevice.getIsReadOnly())); Line 308: struct.put(VdsProperties.SpecParams, vmDevice.getSpecParams()); Line 309: struct.put(VdsProperties.DeviceId, String.valueOf(vmDevice.getId().getDeviceId())); -- To view, visit http://gerrit.ovirt.org/17679 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02579bf1a91cd294a5040acf432f1fdb87eb18c1 Gerrit-PatchSet: 27 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
