Greg Padgett has posted comments on this change.

Change subject: core: adding HA score with proper scheduling policies
......................................................................


Patch Set 7:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/HostedEngineHAClusterWeightPolicyUnit.java
Line 33:             if (isHostedEngine) {
Line 34:                 int maxHaScore = 
hosts.get(0).getHighlyAvailableScore();
Line 35:                 for (VDS host : hosts) {
Line 36:                     if (host.getHighlyAvailableScore() > maxHaScore) {
Line 37:                         maxHaScore = host.getHighlyAvailableScore();
(adding some notes from another discussion) Max is 2400 today.  It could change 
if we make the scoring factors configurable--of course in that case we could 
scale the score in the agent to avoid having to return/track a variable maximum.
Line 38:                     }
Line 39:                 }
Line 40:                 // If the max HA score is zero then we just fill the 
default score.
Line 41:                 // That shouldn't really happen here, as zero or 
negative score hosts were already filtered out


-- 
To view, visit http://gerrit.ovirt.org/20018
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24879ed64cab829969556fd71786b32d3aaaf0c7
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to