Kanagaraj M has posted comments on this change.

Change subject: engine: Query to get gluster volume by task id
......................................................................


Patch Set 5:

(1 comment)

....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java
Line 183:     public GlusterVolumeEntity getVolumeByGlusterTask(Guid taskId) {
Line 184:         GlusterVolumeEntity volume = getCallsHandler().executeRead(
Line 185:                 "GetGlusterVolumeByGlusterTaskId", volumeRowMapper,
Line 186:                 getCustomMapSqlParameterSource().addValue("task_id", 
taskId));
Line 187:         fetchRelatedEntities(volume);
could be NPE if there is no volume found for the given taskId
Line 188:         return volume;
Line 189:     }
Line 190: 
Line 191:     @Override


-- 
To view, visit http://gerrit.ovirt.org/19914
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id02dd690619f2fe204e42a9972f20a6c9ce8146b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to