Tal Nisan has posted comments on this change. Change subject: core: Add read-only disk functionality ......................................................................
Patch Set 6: Code-Review+1 (1 comment) Looks ok, please answer my question and also please move the ui models changes to another patch which will contain the view also otherwise it's pointless .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java Line 62: Line 63: /** Line 64: * The device read-only flag Line 65: */ Line 66: private Boolean isReadOnly; Why change it to a Boolean here? a device can be either read only or not, not much sense in null not to mention that the getter returns false if it's a null Line 67: Line 68: /** Line 69: * The device alias. Line 70: */ -- To view, visit http://gerrit.ovirt.org/15409 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I124176e8feb91b601a71e76dd63051648ec4353a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
