Daniel Erez has posted comments on this change.

Change subject: core:  in PM only selecting apc or ipmilan...
......................................................................


Patch Set 1:

(1 comment)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
Line 1334:         getPmOptions().setIsChangable(isPm);
Line 1335:         getPmOptions().setIsValid(true);
Line 1336:         getPmSecure().setIsChangable(isPm);
Line 1337:         VDSGroup cluster = (VDSGroup) getCluster().getSelectedItem();
Line 1338:         String version = "general"; //$NON-NLS-1$
scratch that.. instead, use: 
'AsyncDataProvider.getDefaultConfigurationVersion()'
(as we're fetching the value using GetDefaultConfigurationVersionQuery).
Line 1339:         if (cluster != null) {
Line 1340:             version = cluster.getcompatibility_version().toString();
Line 1341:         }
Line 1342:         String pmType = (String) getPmType().getSelectedItem();


-- 
To view, visit http://gerrit.ovirt.org/20090
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f815e90d95e8cd21aca51a803dccde8079dee5d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to