Greg Padgett has posted comments on this change. Change subject: vdsm: use startMonitoringDomain ......................................................................
Patch Set 2: Code-Review+1 (1 comment) .................................................... File src/ovirt_hosted_engine_setup/tasks.py Line 124: acquired = False Line 125: while not acquired: Line 126: time.sleep(self.POLLING_INTERVAL) Line 127: self.logger.debug('Waiting for domain monitor') Line 128: response = serv.s.getVdsStats() Maybe repoStats would be more efficient, if there isn't a corner case I'm missing... Line 129: self.logger.debug(response) Line 130: if response['status']['code'] != 0: Line 131: self.logger.debug(response['status']['message']) Line 132: raise RuntimeError(_('Error acquiring VDS status')) -- To view, visit http://gerrit.ovirt.org/19867 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3099081b79d461685901a1a32e9d526bd3bb758a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Leonid Natapov <leonidnata...@gmail.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches