Sahina Bose has posted comments on this change. Change subject: gluster: Remove bricks from DB after commit completion ......................................................................
Patch Set 3: (1 comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CommitRemoveGlusterVolumeBricksCommand.java Line 80: getDbUtils().removeBricksFromVolumeInDb(volume, Line 81: getParameters().getBricks(), Line 82: getParameters().getReplicaCount()); Line 83: releaseVolumeLock(); Line 84: getGlusterVolumeDao().updateVolumeTask(volume.getId(), null); Again, release the lock after volume is updated Line 85: getReturnValue().setActionReturnValue(returnValue.getReturnValue()); Line 86: } Line 87: Line 88: protected void endStepJobCommitted() { -- To view, visit http://gerrit.ovirt.org/20109 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0a21f013833833710abc219c1a066a2250bc5fb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches