Kanagaraj M has posted comments on this change.
Change subject: webadmin: Bricks sub-tab under Hosts
......................................................................
Patch Set 3:
(3 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBricksListModel.java
Line 11: import org.ovirt.engine.ui.uicommonweb.models.SearchableListModel;
Line 12: import org.ovirt.engine.ui.uicompat.ConstantsManager;
Line 13: import org.ovirt.engine.ui.uicompat.PropertyChangedEventArgs;
Line 14:
Line 15: @SuppressWarnings("unused")
is this required?
Line 16: public class HostBricksListModel extends SearchableListModel
Line 17: {
Line 18:
Line 19: @Override
Line 44: @Override
Line 45: protected void entityPropertyChanged(Object sender,
PropertyChangedEventArgs e)
Line 46: {
Line 47: super.entityPropertyChanged(sender, e);
Line 48: getSearchCommand().execute();
we don't need to refresh the brick list in case of property changes
Line 49: }
Line 50:
Line 51: @Override
Line 52: public void search()
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostBrickView.java
Line 12: import
org.ovirt.engine.ui.webadmin.section.main.presenter.tab.host.SubTabHostBrickPresenter;
Line 13: import
org.ovirt.engine.ui.webadmin.section.main.view.AbstractSubTabTableView;
Line 14: import
org.ovirt.engine.ui.webadmin.widget.table.column.BrickStatusColumn;
Line 15:
Line 16: public class SubTabHostBrickView extends AbstractSubTabTableView<VDS,
GlusterBrickEntity, HostListModel, HostBricksListModel>
HostBrickListModel would be more appropriate than HostBricksListModel if you
look at the presenter and view names
Line 17: implements SubTabHostBrickPresenter.ViewDef {
Line 18:
Line 19: @Inject
Line 20: public
SubTabHostBrickView(SearchableDetailModelProvider<GlusterBrickEntity,
HostListModel, HostBricksListModel> modelProvider, ApplicationConstants
constants) {
--
To view, visit http://gerrit.ovirt.org/19989
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic67c2aba2a5cd90832e6aa8c63c016ccef96ee50
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
