Alon Bar-Lev has posted comments on this change. Change subject: core: Remove Windows ProductKey* from db ......................................................................
Patch Set 6: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/config/productkey_upgrade.py Line 61: ) Line 62: Line 63: def _misc(self): Line 64: if os.path.exists(osetupcons.FileLocations.EXTRACTED_PRODUCTKEYS): Line 65: return this is procedural language convention... each block (and subblock recursively) have one entry point and one exit point. exceptional programing states that every block have one entry point and two exit points (normal, exceptional). spaghetti programming = everything else :) so unless absolutely required for some sane reason that usually results from inappropriate code structure, I prefer to stick with the basics (not BASIC). Line 66: Line 67: content = [] Line 68: for key in self.DB_TO_OSINFO.keys(): Line 69: val = self.environment[osetupcons.DBEnv.STATEMENT].getVdcOption(key) -- To view, visit http://gerrit.ovirt.org/19743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I876894e7ba5fcd28ee0d435b4a2561f662140174 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
