Sahina Bose has uploaded a new change for review. Change subject: engine: Fix findbug error - possible NPE ......................................................................
engine: Fix findbug error - possible NPE FindBug returned this error of possible NPE though the Dao returns an empty list and not null. Change-Id: I73a087ed678f8fffca9aabbb56bf1baacb5a0a44 Signed-off-by: Sahina Bose <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java 1 file changed, 15 insertions(+), 14 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/03/20103/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java index 184390d..c20e296 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java @@ -105,20 +105,21 @@ return null; } }); - } - //update status in step table - for (Step step: steps) { - if (step.getEndTime() != null) { - //we have already processed the task - continue; - } - step.setDescription(getTaskMessage(cluster,step.getStepType(),task)); - if (hasTaskCompleted(task)) { - step.markStepEnded(task.getStatus()); - endStepJob(step); - releaseVolumeLock(task.getTaskId()); - } else { - getJobRepository().updateStep(step); + } else { + //update status in step table + for (Step step: steps) { + if (step.getEndTime() != null) { + //we have already processed the task + continue; + } + step.setDescription(getTaskMessage(cluster,step.getStepType(),task)); + if (hasTaskCompleted(task)) { + step.markStepEnded(task.getStatus()); + endStepJob(step); + releaseVolumeLock(task.getTaskId()); + } else { + getJobRepository().updateStep(step); + } } } -- To view, visit http://gerrit.ovirt.org/20103 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I73a087ed678f8fffca9aabbb56bf1baacb5a0a44 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
