[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: webadmin, userportal: (WiP) Use GWT standard RPC instead of d...

[vszocs]

Vojtech Szocs has uploaded a new change for review.

Change subject: webadmin,userportal: (WiP) Use GWT standard RPC instead of deRPC
......................................................................

webadmin,userportal: (WiP) Use GWT standard RPC instead of deRPC

[!] Important [!]
Patch currently as Work-in-Progress, do NOT merge at this stage.

deRPC is a variation of GWT RPC which is officially deprecated
and never made it out of "EXPERIMENTAL" stage. We used deRPC
because of serialization issues when passing objects such as
VdcReturnValueBase (containing 'java.lang.Object returnValue')
between frontend and backend.

This patch makes frontend and backend use GWT standard RPC
instead of deRPC. Custom field serializers are still in use
after applying this patch and everything seems to work just
like before.

This patch should be carefully tested before merging.

Change-Id: Ib6a4a6ef2eb620cf7050b7c7c2688cadc3b9d6f5
Signed-off-by: Vojtech Szocs <vsz...@redhat.com>
---
M 
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
M 
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/gwtservices/GenericApiGWTService.java
M 
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
3 files changed, 9 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/01/20101/1

diff --git 
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
 
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
index 210eb7d..5710af2 100644
--- 
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
+++ 
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
@@ -164,6 +164,11 @@
             errorMessage =
                     getConstants().requestToServerFailed()
                             + ": " + caught.getLocalizedMessage(); 
//$NON-NLS-1$
+            // TODO debug
+            errorMessage += " | ClassName " + caught.getClass().getName(); 
//$NON-NLS-1$
+            for (StackTraceElement e : caught.getStackTrace()) {
+                errorMessage += " | StackTraceElement " + e.toString(); 
//$NON-NLS-1$
+            }
         }
         failureEventHandler(errorMessage);
     }
diff --git 
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/gwtservices/GenericApiGWTService.java
 
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/gwtservices/GenericApiGWTService.java
index 3285eca..60d912f 100644
--- 
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/gwtservices/GenericApiGWTService.java
+++ 
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/gwtservices/GenericApiGWTService.java
@@ -10,9 +10,9 @@
 import org.ovirt.engine.core.common.queries.VdcQueryType;
 import org.ovirt.engine.core.common.users.VdcUser;
 
-import com.google.gwt.rpc.client.RpcService;
+import com.google.gwt.user.client.rpc.RemoteService;
 
-public interface GenericApiGWTService extends RpcService {
+public interface GenericApiGWTService extends RemoteService {
 
     public VdcQueryReturnValue RunQuery(VdcQueryType search,
             VdcQueryParametersBase searchParameters);
diff --git 
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
 
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
index 780947a..3a1b3e9 100644
--- 
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
+++ 
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
@@ -21,10 +21,10 @@
 import org.ovirt.engine.core.common.users.VdcUser;
 import org.ovirt.engine.ui.frontend.gwtservices.GenericApiGWTService;
 
-import com.google.gwt.rpc.server.RpcServlet;
 import com.google.gwt.user.client.rpc.SerializationException;
+import com.google.gwt.user.server.rpc.RemoteServiceServlet;
 
-public class GenericApiGWTServiceImpl extends RpcServlet implements 
GenericApiGWTService {
+public class GenericApiGWTServiceImpl extends RemoteServiceServlet implements 
GenericApiGWTService {
 
     private static final long serialVersionUID = 7395780289048030855L;
 


-- 
To view, visit http://gerrit.ovirt.org/20101
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib6a4a6ef2eb620cf7050b7c7c2688cadc3b9d6f5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches