Gilad Chaplik has posted comments on this change.
Change subject: core: Log filtering progress in scheduling
......................................................................
Patch Set 6:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 681: for (Map.Entry<Guid, String> vds:
schedulingResult.getReasons()) {
Line 682: errorMessage.append(String.format("%s: %s\n",
vds.getKey().toString(), vds.getValue()));
Line 683: }
Line 684: getReturnValue().setDescription(errorMessage.toString());
Line 685:
I think we should remove these part, and print a message to log instead within
SchedulingManager.
Line 686: VmHandler.updateVmGuestAgentVersion(getVm());
Line 687: setVds(null);
Line 688: setVdsName(null);
Line 689: if (getVdsId().equals(Guid.Empty)) {
--
To view, visit http://gerrit.ovirt.org/19213
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4edcc33b0d280ab92e3c98d8d5a7a75386592e32
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
