Martin Sivák has posted comments on this change. Change subject: Samples: score by similar os for ksm ......................................................................
Patch Set 2: (1 comment) It looks OK, but I had one small comment to the style. .................................................... File plugins/examples/ksm_same_os_score.py Line 39: host_vms = self._get_vms(host.name, connection) Line 40: if not host_vms: Line 41: return (host.id, 0) Line 42: for host_vm in host_vms: Line 43: if(vm.get_os().get_type() == host_vm.get_os().get_type()): We do not use brackets around conditions in Python. Line 44: if(vm.get_os().get_version() == host_vm.get_os().get_version()): Line 45: score += 100 Line 46: else: Line 47: score += 20 -- To view, visit http://gerrit.ovirt.org/20033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfb359ecbd73a1f4a2520ac8a65b753449be55bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-scheduler-proxy Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslom...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Noam Slomianko <nslom...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
