Omer Frenkel has posted comments on this change.
Change subject: engine: VM Device Type for Display Type
......................................................................
Patch Set 8:
(2 comments)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
Line 297: protected abstract void readOsSection(XmlNode section);
Line 298:
Line 299: protected abstract void readHardwareSection(XmlNode section);
Line 300:
Line 301: protected abstract VmDeviceType getDisplayDevice(DisplayType
displayType);
looking at the implementation of this method, it seems that it could be
implemented here with vmBase.getOsId() and getVersion()
Line 302:
Line 303: protected void readGeneralData() {
Line 304: XmlNode content = _document.SelectSingleNode("//*/Content");
Line 305: XmlNode node;
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 79: * Add video device according to the given display type
Line 80: */
Line 81: private void addVideoCardByDisplayType(DisplayType displayType,
int numOfMonitors) {
Line 82: Map<String, Object> struct = new HashMap<String, Object>();
Line 83: VmDeviceType vmDeviceType =
getOsRepository().getDisplayDevice(vm.getOs(),
vm.getVdsGroupCompatibilityVersion(), vm.getDefaultDisplayType());
should use given display in parameters
Line 84: // create a monitor as an unmanaged device
Line 85: struct.put(VdsProperties.Type,
VmDeviceGeneralType.VIDEO.getValue());
Line 86: struct.put(VdsProperties.Device, vmDeviceType);
Line 87: struct.put(VdsProperties.SpecParams,
getNewMonitorSpecParams(displayType, numOfMonitors));
--
To view, visit http://gerrit.ovirt.org/18677
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I326f8aaf0de95332436499205f90336d2f4e73d7
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<gustavo.pedr...@eldorado.org.br>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
